Remove Nano S target #262
Merged
Remove Nano S target #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #262 +/- ##
==========================================
Coverage ? 84.77%
==========================================
Files ? 17
Lines ? 2187
Branches ? 0
==========================================
Hits ? 1854
Misses ? 333
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bigspider
force-pushed
the
goodbye-nanos
branch
4 times, most recently
from
883ad6e
to
42f8622
Compare
… using a hardcoded binary
…Nano S; default to 'nanosp' in tests
Co-authored-by: François Beutin <[email protected]>
fbeutin-ledger
approved these changes
Jun 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Nano S compilation target. Also removes some RAM and code size optimizations that are not longer worth the added code complexity.
The latest Nano S version is kept in the nanos branch.