Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the nanoS support in boilerplate #128

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

tdejoigny-ledger
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (d7a48b2) to head (eacb213).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files           3        3           
  Lines          53       53           
=======================================
  Hits           44       44           
  Misses          9        9           
Flag Coverage Δ
unittests 83.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@agrojean-ledger
Copy link
Contributor

@tdejoigny-ledger something is wrong with the CI

@tdejoigny-ledger
Copy link
Contributor Author

@tdejoigny-ledger something is wrong with the CI
I suppose it will be fixed right after the merge.

Copy link
Contributor

@fbeutin-ledger fbeutin-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to add the new nanos branch on all workflow triggers

on:
  push:
    branches:
      - master
      - main
      - develop
      - TODO

We need to do this on nanos branch AND on develop branch

@fbeutin-ledger
Copy link
Contributor

I suggest we split this PR in two commits:

  • C1: first one to fix the tools (codeql, workflow, triggers)
  • C2: second one to drop lns support

Then we can re-do the fork lns from the clean commit C1

@tdejoigny-ledger tdejoigny-ledger merged commit a08a798 into master Jul 30, 2024
47 checks passed
@tdejoigny-ledger tdejoigny-ledger deleted the tdj/remove_nanoS_support branch July 30, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants