-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and update PulseChain Networks #626
Conversation
f1efae6
to
fede1fd
Compare
26ed637
to
23e4e72
Compare
23e4e72
to
6872591
Compare
Hello @bretep, thank you for this PR. We now don't allow clone applications (with separate .mk files) that only use Ethereum's derivation path, since they will work just fine directly with the Ethereum app directly. If you could update your PR by :
Thank you! 🙏 |
6872591
to
6222b9a
Compare
6222b9a
to
00aa4c8
Compare
@apaillier-ledger, Thank you for that excellent review and feedback. I've done the following:
Please let me know if I need to fix anything else. I appreciate your help. |
@apaillier-ledger I guess my only concern is I'm guessing it will be fine, but I want to make sure we're not overlooking anything. Most other Ethereum chains do not have a beacon chain; they use ETH1. Reference: |
@bretep, it should behave with the Ethereum app the same way as it would have with the separate clone app. |
Description
Please provide a detailed description of what was done in this PR.
(And mentioned if linked to an issue docs)
Changes include
Additional comments
Support for PulseChain was missed during updates earlier this year. I've added it back following the new patterns.
Ledger Live integration: LedgerHQ/ledger-live#7607