Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pycrypto with pycryptodome #44

Closed
erickearns opened this issue May 18, 2018 · 1 comment
Closed

Replace pycrypto with pycryptodome #44

erickearns opened this issue May 18, 2018 · 1 comment

Comments

@erickearns
Copy link

Using ledgerblue in coordination with various Ethereum tools (e.g. https://github.com/ethereum/web3.py/blob/master/setup.py#L27) is problematic as pycryptodome has replaced pycrypto in most modern tool dependency trees. As pycryptodome is largely a drop-in replacement for pycrypto, updating this dependency would solve a significant amount of headache.

@redshiftzero
Copy link

Heads up, we made this same change in SecureDrop, replacing pycrypto with pycryptodome (ref: freedomofpress/securedrop#2903). However, since we did that we were strongly advised for security reasons to move away from pycryptodome to pyca/cryptography (refs: PyCQA/bandit#307, freedomofpress/securedrop#3399, freedomofpress/securedrop#3458). If using audited crypto libraries is important for this project, you may want to do the same, though I understand that this may be significantly more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants