Cosmos JS (#1801)

* be more conform between optimistic and final operation

* use old code logic

* fix senders/recipients regression

* fix duplicate data

* fix duplicate data (again)

* append block height

* fix specific empty amount case in reward transaction

* temporary debug operation broadcasted

* use toOperationRaw method

* return  patchedOperation

* restore broadcast operation

* Update js-synchronisation.ts

* remove block height support

Co-authored-by: Alexandre Alouit <[email protected]>

src/families/cosmos/api/Cosmos.ts

@@ -3,8 +3,6 @@ import BigNumber from "bignumber.js";
 import network from "../../../network";
 import { Operation } from "../../../types";
 import { patchOperationWithHash } from "../../../operation";
-import { log } from "@ledgerhq/logs";
-import { toOperationRaw } from "../../../account";
 
 const defaultEndpoint = getEnv(
   "API_COSMOS_BLOCKCHAIN_EXPLORER_API_ENDPOINT"
@@ -283,12 +281,5 @@ export const broadcast = async ({
     );
   }
 
-  const patchedOperation = patchOperationWithHash(
-    { ...operation, blockHeight: data.tx_response.height },
-    data.tx_response.txhash
-  );
-
-  log("info", "debug operation: ", toOperationRaw(patchedOperation));
-
-  return patchedOperation;
+  return patchOperationWithHash(operation, data.tx_response.txhash);
 };

src/families/cosmos/js-synchronisation.ts

@@ -1,4 +1,4 @@
-import { Account, Operation } from "../../types";
+import { Account, Operation, OperationType } from "../../types";
 import { BigNumber } from "bignumber.js";
 import { makeSync, GetAccountShape, mergeOps } from "../../bridge/jsHelpers";
 import { encodeAccountId } from "../../account";
@@ -20,13 +20,13 @@ const txToOps = (info: any, id: string, txs: any): Operation[] => {
     const op: Operation = {
       id: "",
       hash: tx.txhash,
-      type: "" as any,
+      type: "" as OperationType,
       value: new BigNumber(0),
       fee: fees,
       blockHash: null,
-      blockHeight: tx.height,
-      senders: [] as any,
-      recipients: [] as any,
+      blockHeight: null,
+      senders: [] as string[],
+      recipients: [] as string[],
       accountId: id,
       date: new Date(tx.timestamp),
       extra: {