Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Feature Branch for Ripple (XRP) family #1764

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

gre
Copy link
Contributor

@gre gre commented Mar 1, 2022

branch dedicated to XRP implementation that will run a dedicated bot on each commit.

@gre gre requested a review from a team March 1, 2022 09:47
@gre gre requested a review from a team as a code owner March 1, 2022 09:47
@vercel
Copy link

vercel bot commented Mar 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/3ssTNCscgkKNxSL2arFEGbQR3EWp
✅ Preview: https://ledger-live-common-git-family-ripple-ledgerhq.vercel.app

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #1764 (1a3fa87) into develop (bcd322c) will decrease coverage by 29.18%.
The diff coverage is 99.11%.

@@             Coverage Diff              @@
##           develop    #1764       +/-   ##
============================================
- Coverage    58.04%   28.85%   -29.19%     
============================================
  Files          450      451        +1     
  Lines        20532    20415      -117     
  Branches      5271     5246       -25     
============================================
- Hits         11917     5891     -6026     
- Misses        8586    14517     +5931     
+ Partials        29        7       -22     
Impacted Files Coverage Δ
src/env.ts 78.26% <ø> (-4.35%) ⬇️
src/families/ripple/js-synchronization.ts 98.03% <98.03%> (ø)
src/api/Ripple.ts 100.00% <100.00%> (+7.79%) ⬆️
src/families/ripple/bridge/js.ts 84.93% <100.00%> (-1.11%) ⬇️
src/families/bitcoin/wallet-btc/crypto/factory.ts 3.61% <0.00%> (-89.16%) ⬇️
src/families/bitcoin/wallet-btc/xpub.ts 2.95% <0.00%> (-88.76%) ⬇️
src/families/cosmos/js-synchronisation.ts 9.00% <0.00%> (-86.49%) ⬇️
...bitcoin/wallet-btc/pickingstrategies/CoinSelect.ts 8.79% <0.00%> (-85.72%) ⬇️
src/families/bitcoin/js-synchronisation.ts 13.14% <0.00%> (-83.43%) ⬇️
src/families/solana/api/queued.ts 16.66% <0.00%> (-83.34%) ⬇️
... and 240 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcd322c...1a3fa87. Read the comment docs.

@gre gre changed the title Rework XRP implementation for LIVE-1341 Feature Branch for XRP Mar 1, 2022
@gre gre changed the title Feature Branch for XRP Feature Branch for Ripple (XRP) family Mar 1, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome rework 💪
A couple comments but nothing blocking I think.

src/families/ripple/js-synchronization.ts Outdated Show resolved Hide resolved
src/api/Ripple.ts Show resolved Hide resolved
src/families/ripple/js-synchronization.ts Show resolved Hide resolved
src/families/ripple/js-synchronization.ts Outdated Show resolved Hide resolved
src/families/ripple/js-synchronization.ts Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Apr 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) Apr 28, 2022 at 8:18PM (UTC)

@ghost ghost added the feature ready label Apr 29, 2022
@ghost
Copy link

ghost commented Apr 29, 2022

Tests failures are random unrelated timeouts, only on Windows and MacOS.
Sorry about that 🙏 but doesn't prevent merging.

@lambertkevin lambertkevin changed the base branch from develop to release/22.1.x May 5, 2022 13:17
@valpinkman valpinkman merged commit 1d186c0 into release/22.1.x May 5, 2022
@valpinkman valpinkman deleted the family/ripple branch May 5, 2022 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants