Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Bugfix - Add missing update for NFT architecture in CLI #1872

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Bugfix - Add missing update for NFT architecture in CLI #1872

merged 1 commit into from
Apr 8, 2022

Conversation

lambertkevin
Copy link
Contributor

Context (issues, jira)

Missing nftResolvers notion in CLI.

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@lambertkevin lambertkevin requested a review from a team as a code owner April 8, 2022 10:16
@lambertkevin lambertkevin requested a review from a team April 8, 2022 10:16
@lambertkevin lambertkevin requested a review from a team as a code owner April 8, 2022 10:16
@vercel
Copy link

vercel bot commented Apr 8, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/3Qk2JEARS6M3GFnNSzMcGubd9hfB
✅ Preview: https://ledger-live-common-git-bugfix-add-missing-updat-f3ed3b-ledgerhq.vercel.app

@lambertkevin lambertkevin force-pushed the bugfix/add-missing-update-for-nft-cli branch from 996f742 to 25f03f0 Compare April 8, 2022 11:00
@lambertkevin lambertkevin force-pushed the bugfix/add-missing-update-for-nft-cli branch from 0871a8c to 25f03f0 Compare April 8, 2022 11:15
@lambertkevin lambertkevin changed the base branch from develop to release/v22.0.0 April 8, 2022 11:15
@lambertkevin lambertkevin merged commit aaa8e11 into release/v22.0.0 Apr 8, 2022
@lambertkevin lambertkevin deleted the bugfix/add-missing-update-for-nft-cli branch April 8, 2022 11:15
lambertkevin added a commit that referenced this pull request Apr 8, 2022
@lambertkevin
Fix new architecture nftsResolvers in cli (#1872)
22f5d82
lambertkevin added a commit that referenced this pull request Apr 8, 2022
@lambertkevin
Fix new architecture nftsResolvers in cli (#1872)
1449ed2
lambertkevin added a commit that referenced this pull request Apr 8, 2022
@lambertkevin
Fix new architecture nftsResolvers in cli (#1872)
3490c47
lambertkevin added a commit that referenced this pull request Apr 8, 2022
@lambertkevin
Fix new architecture nftsResolvers in cli (#1872)
f9df8f0
lambertkevin added a commit that referenced this pull request Apr 11, 2022
@lambertkevin @LFBarreto
@hzheng-ledger @gre @hakim-adamik @thomas-nguy @dependabot @konoart
Release/v22.0.0 (#1871)
acadece 
* Revert "Merge pull request #1853 from LedgerHQ/release/v22.0.0"

This reverts commit 78650fe, reversing
changes made to 7ef865d.

* (Solana): fix missing superstruct dependency -> making app crashes

* v21.36.2

* LL-1589 more robust bitcoin retry (#1835)

* fix bot

* fix sync error exception process

* fix bch address convert issue (#1847)

* LIVE-1890 Replace all deprecated uses of open(deviceId) with withDevice (#1856)

* Remove all libcore codebase (#1831)

* Remove all libcore codebase

* trigger some bot (commit to revert before merging this PR)

* lint

* remove useless cli test run

* fix type issue

* cli update

* Revert "trigger some bot (commit to revert before merging this PR)"

This reverts commit add2667.

* update cli/README

* fix merge

* Cosmos js (#1832)

Document Nano app limitations + minor fix on reward amounts

* Modularize the all.libcore.tests (#1834)

* Additional cleanup on bitcoin implem

* LIVE-1873

Co-authored-by: wa-aal <[email protected]>
Co-authored-by: haammar-ledger <[email protected]>

* Add ETH goerli (#1841)

* add ETH goerli

* add goerli test

* Cosmos fixes (#1846)

* Set bot on family/cosmos branch

* LIVE-1873

* trigger bot

* Family/crypto org (#1852)

* LIVE-1743 Fix crypto.com address derivation path (#1836)

* trigger bot

* Tentative to fix crypto.com use of address

Co-authored-by: Thomas Nguy <[email protected]>

* [LIVE-1174] - Feature: Upgrade NFT Architecture (#1805)

* Fix wrong NFTResource typing

* Update NFT types to ProtoNFT

* Update NFT Id to contain currency

* Update NFT Helpers for new model

* Update Eth API metadata call to include chainId

* Move nft metadata resolution to bridge

* Update NftMetadaProvider logic to use bridge

* Update prepare tx of ERC721/1155 w/ new model

* Update CLI for new NFT model

* Add getNftCapabilities to nft support

* Naming + fixing ERC1155 quantity potentially falsy

* Make CLI use the LLC branch hash

* Add type to nftMetadataResolver param + use of sync metadata

* Remove useless import

* Remove useless comment in CLI formatters

* Add comment to nftsByCollection helper

* Add comments + types to NFT metadata call batchers

* Fix sync metadata resolution for Eth family

* Add return type to nftMetadataResolver + decodeNftId

* Add polygon to NFT currencies (#1848)

* [LIVE-1909] - Bugfix: OpenSea Lazy mint quantity fix (#1862)

* Fix lazyminting issue for nfts quantity

* run ci

* Reset CLI LLC dep

* Fix nft operations wrong order to infer balance (#1865)

* [LIVE-1911][LIVE-1912] Feature - Add collection name resolver to eth familly (#1863)

* Change nfts resolvers from Bridge type

* Update eth nft resolvers & add collection resolver

* Add loadCollectionMetadata to nft context

* Change eth NFT prepareTransaction to use collection call instead of nft metadata call

* Bump plist from 3.0.4 to 3.0.5 in /mobile-test-app (#1849)

Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.4 to 3.0.5.
- [Release notes](https://github.com/TooTallNate/node-plist/releases)
- [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md)
- [Commits](https://github.com/TooTallNate/node-plist/commits)

---
updated-dependencies:
- dependency-name: plist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump cocoapods-downloader from 1.3.0 to 1.6.3 in /mobile-test-app (#1857)

Bumps [cocoapods-downloader](https://github.com/CocoaPods/cocoapods-downloader) from 1.3.0 to 1.6.3.
- [Release notes](https://github.com/CocoaPods/cocoapods-downloader/releases)
- [Changelog](https://github.com/CocoaPods/cocoapods-downloader/blob/master/CHANGELOG.md)
- [Commits](CocoaPods/cocoapods-downloader@1.3.0...1.6.3)

---
updated-dependencies:
- dependency-name: cocoapods-downloader
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ansi-regex from 3.0.0 to 3.0.1 (#1850)

Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](chalk/ansi-regex@v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: ansi-regex
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Solana staking (#1844)

* solana add initial staking support

* solana improve staking

* solana fix typos

* solana fix cli format for staking

* solana add device fields for stake create acc

* solana add stake delegate support

* solana fix lint

* solana add stake undelegate

* solana add stake withdraw

* solana add stake split

* solana add stakes loading

* solana improve staking

* solana introduce solana resources

* solana add preload data

* solana add hydrate to bridge

* solana add stake actions

* solana improve staking

* solana add meta to validators

* solana add validator name

* solana fix seed for stake accs

* solana add stake reward

* solana improve staking

* solana stake add withdrawable amount

* solana refactor framework

* solana fix tests

* solana make auto delegation mandatory

* solana sort stakes

* solana fix error key

* solana add delegation validator validation

* solana add staking create acc tests

* solana add staking delegate tests

* solana add stake undelegate tests

* solana remove redundant checks for stake delegation

* solana skip options validations on cli level

* solana skip undelegate options validations on cli level

* solana improve staking tests

* solana add delegatable check to staking

* solana fix estimate max spendable

* solana add delegation active test

* solana add stake state tests

* solana introduce validators app validators

* solana add validators for testnet & devnet

* solana refactor validators app validators

* solana update meta of stakes

* solana update sort order of stakes

* solana add delegated op type

* solana shuffle staking validators

* solana fix stake withdraw optimistic value

* solana clean comments

* solana update mock data

* solana add initial staking bot specs

* solana add staking bot specs

* solana move ledger vote acc to utils

* solana add swap util

* solana update device tx config

* solana fix lint

* Add bot for Solana

* Solana staking integration (#1825)

* solana add initial staking support

* solana improve staking

* solana fix typos

* solana fix cli format for staking

* solana add device fields for stake create acc

* solana add stake delegate support

* solana fix lint

* solana add stake undelegate

* solana add stake withdraw

* solana add stake split

* solana add stakes loading

* solana improve staking

* solana introduce solana resources

* solana add preload data

* solana add hydrate to bridge

* solana add stake actions

* solana improve staking

* solana add meta to validators

* solana add validator name

* solana fix seed for stake accs

* solana add stake reward

* solana improve staking

* solana stake add withdrawable amount

* solana refactor framework

* solana fix tests

* solana make auto delegation mandatory

* solana sort stakes

* solana fix error key

* solana add delegation validator validation

* solana add staking create acc tests

* solana add staking delegate tests

* solana add stake undelegate tests

* solana remove redundant checks for stake delegation

* solana skip options validations on cli level

* solana skip undelegate options validations on cli level

* solana improve staking tests

* solana add delegatable check to staking

* solana fix estimate max spendable

* solana add delegation active test

* solana add stake state tests

* solana introduce validators app validators

* solana add validators for testnet & devnet

* solana refactor validators app validators

* solana update meta of stakes

* solana update sort order of stakes

* solana add delegated op type

* solana shuffle staking validators

* solana fix stake withdraw optimistic value

* solana clean comments

* solana update mock data

* solana add initial staking bot specs

* solana add staking bot specs

* solana move ledger vote acc to utils

* solana add swap util

* solana update device tx config

* solana fix lint

* Change seed for Solana bot

* Change seed again for Solana bot

* trigger bot

* solana add stake percent calc fn

* solana update spec for new nano app

* solana set minimum required nano app version

* solana add validators app url env variable

* fix bad merge

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* Solana bot - increase timeout and decrease minimum to delegate

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* Setup the bot to not use the validators.app proxy (yet)

* Replace all deprecated uses of open(deviceId) with withDevice

* Solana - replace open(deviceId) with withDevice

* Remove custom data

* Update solana bot

Co-authored-by: konoart <[email protected]>
Co-authored-by: konoart <[email protected]>
Co-authored-by: lambertkevin <[email protected]>

* v22.0.0

* Fix new architecture nftsResolvers in cli (#1872)

* Update snapshots

* Introduce a way to ignore preload data in dataset tests (#1875)

Co-authored-by: LFBarreto <[email protected]>
Co-authored-by: hzheng-ledger <[email protected]>
Co-authored-by: Hakim <[email protected]>
Co-authored-by: @greweb <[email protected]>
Co-authored-by: wa-aal <[email protected]>
Co-authored-by: haammar-ledger <[email protected]>
Co-authored-by: Thomas Nguy <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: konoart <[email protected]>
Co-authored-by: konoart <[email protected]>
@lambertkevin lambertkevin restored the bugfix/add-missing-update-for-nft-cli branch April 11, 2022 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lambertkevin