Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

Support: fix build by adding @cosmjs/amino dependency #1925

Merged
2 commits merged into from
May 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 2, 2022

Context (issues, jira)

Live Common doesn't build.

src/families/cosmos/js-synchronisation.ts:11:53 - error TS2307: Cannot find module '@cosmjs/amino' or its corresponding type declarations.

11 import { pubkeyToAddress, decodeBech32Pubkey } from "@cosmjs/amino";

Description / Usage

Issue happens since #1913 where dependency to @cosmjs/ledger-amino was removed.
Unclear why CI was green on that PR 😕

The fix consists is adding only the @cosmjs/amino dependency.

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@ghost ghost self-requested a review as a code owner May 2, 2022 08:58
@vercel
Copy link

vercel bot commented May 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) May 2, 2022 at 9:00AM (UTC)

@ghost ghost merged commit 8b92f12 into develop May 2, 2022
@ghost ghost deleted the support/add-cosmjs-amino-dep branch May 2, 2022 12:31
This was referenced May 5, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants