This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Add ETH goerli #4876
Merged
Add ETH goerli #4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution.
Why /generate-screenshots ?If your PR contains UI related changes, |
Coverage report
Test suite run success1 tests passing in 1 suite.Report generated by 🧪jest coverage report action from d8d499e |
ghost
reviewed
Mar 30, 2022
There was a problem hiding this comment.
- Need to re-generate the cryptoassets.md file by running this:
yarn test --runTestsByPath src/generate-cryptoassets-md.test.js - Maybe need to update this file: https://github.com/LedgerHQ/ledger-live-desktop/blob/feat/LL-1766/tests/specs/devmode.spec.ts#L11
Fixed |
ghost
approved these changes
Apr 5, 2022
|
/generate-screenshots |
|
/generate-screenshots |
lambertkevin
force-pushed
the
feat/LL-1766
branch
from
62fa50e
to
8dedbfb
Compare
lambertkevin
added a commit
that referenced
this pull request
Apr 5, 2022
* add ETH goerli * regenerate cryptoassets * update screenshots (windows) * update screenshots (linux) * Update LLC dep to future v22.0.0 Co-authored-by: Team Live <[email protected]> Co-authored-by: lambertkevin <[email protected]>
Merged
lambertkevin
added a commit
that referenced
this pull request
Apr 11, 2022
* add ETH goerli * regenerate cryptoassets * update screenshots (windows) * update screenshots (linux) * Update LLC dep to future v22.0.0 Co-authored-by: Team Live <[email protected]> Co-authored-by: lambertkevin <[email protected]>
lambertkevin
added a commit
that referenced
this pull request
Apr 20, 2022
* add ETH goerli * regenerate cryptoassets * update screenshots (windows) * update screenshots (linux) * Update LLC dep to future v22.0.0 Co-authored-by: Team Live <[email protected]> Co-authored-by: lambertkevin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ledgerhq.atlassian.net/browse/LIVE-1766
