-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: native dApp support [LIVE-9527] #6328
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
Just FYI using the We get this error caught in the catch block( https://github.com/LedgerHQ/ledger-live/pull/6328/files#diff-59e2fd754b520d4fb4a88e193bddb176538cb4bf93fcd688179e333c391298d5R607-R613 ) : Passing a This behaviour is fixed in their v6 ethers-io/ethers.js#3623 (comment) When forcing chainId to be "1" for instance I get the correct UI back: |
966fe03
to
b4c53f8
Compare
96335ce
to
dfbe366
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@expo/[email protected] |
Simplify some of the hooks and remove unneeded code
efca710
to
4ba28a3
Compare
2b93b13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA is not mandatory for the review as of now .
📝 Description
Migration from ETH dApp Browser Live App and iframe-provider to support inside LL directly injecting an EIP 6963 compatible provider in the WebView, using params from the manifest.
ℹ️ For reviewers, explanatory gist of changes: https://gist.github.com/Wozacosta/efca37c582b23bd2702307fc49aa620d/
You can test using the manifest below
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
npx changeset
was attached.dapp
field🧐 Checklist for the PR Reviewers
-The PR has been tested thoroughly, and any potential edge cases have been considered and handled.