This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
[fix] allow asset importers to define which content they can load #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ethereum plugins as defined in https://github.com/LedgerHQ/ledger-asset-dapps/ don't necessarily have a
b2c.json
file anymore, in which case they should just be ignored by the Live for now as they are only defined for B2B.The
ethereum-plugins.js
importer fails to load the plugin in question, and raises an exception that is properly caught and logged by the main script.However the error can be scary, and does not need to be raised in this case, so I added the notion of
shouldLoad
which allows importers to decide whether to skip a file or not. This notion already existed implicitly (checking if the file is a JSON), and I have simply extended it.Let me know if this implementation suits you =]