Add Click the tree explorer should open the topic (#132) #186

xuzaixian · 2019-03-05T09:55:15Z

Resolve #131

jdneo · 2019-03-05T10:16:07Z

@xuzaixian Thank you for contribution.

From my understanding, after applying this change, when the user clicks on the tree node, we will generate new / open existing problem file, right?

xuzaixian · 2019-03-05T10:25:36Z

yes ~

jdneo · 2019-03-05T10:40:53Z

Emm, I'm ok to open the existing problem file.

While for the non-existing file, it will be better if we can first show the problem description to the user, and generate the file if the user has some further confirmation action. What do you think?

xuzaixian · 2019-03-06T02:36:17Z

Hum....maybe we can preview the problem within a webview , and generate the file after confirmation action ?

jdneo · 2019-03-06T02:59:04Z

@xuzaixian Exactly what I'm thinking about. And this action can be bound with a new command called Preview Problem.

Would you like to have a try to implement this feature first?

xuzaixian · 2019-03-06T06:46:14Z

ok, i will work on it.

jdneo · 2019-03-06T06:49:28Z

@xuzaixian I'm thinking that if we should create a new command or just reuse Show Problem

xuzaixian · 2019-03-06T07:06:40Z

I prefer to create a new command Preview Problem .

use 'Show Problem' when they want to code right now
use 'Preview Problem' when they want to read description.
we can provide more choices to user 🤣

jdneo · 2019-03-06T07:22:54Z

@xuzaixian So what should we do when user left-click on the node?

xuzaixian · 2019-03-06T07:40:37Z

@jdneo How about just preview the problem description when user left-click?
We can provide an extra button called Code Now or something else .. in preview window,
The user can click button to code right away.
Also provide a new menu option in right-click menu called Code Now.

This sounds convenient.

jdneo · 2019-03-06T07:42:02Z

@xuzaixian Yes, sounds good

jdneo · 2019-03-06T10:47:51Z

Hi @xuzaixian,

I noticed that a lot of diffs is caused by reformating the package.json. Would you mind to revert those formatting changes? This could make it easier to review.

Thanks!

xuzaixian · 2019-03-06T12:05:09Z

sorry for that 😢

package.json

src/commands/show.ts

src/explorer/LeetCodeNode.ts

src/shared.ts

src/utils/webviewUtils.ts

src/explorer/LeetCodeNode.ts

Remove unused function Use rem instead of px Use the VS Code embed CSS vars in Preivew Webview Use spaces instead of tabs in package.json Use previewProvider to manage preivew logic

jdneo · 2019-03-08T08:20:52Z

@xuzaixian You can install an extension called: TS Lint, to help you resolve those lint errors.

https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin

xuzaixian · 2019-03-08T09:01:54Z

@jdneo
There is no error in my environment when i run vsce package
But The Travis CI build failed.
Can you take a look ?

jdneo · 2019-03-08T10:26:18Z

@xuzaixian It's because the file system on Linux is case sensitive.

your file name is leetcodePreviewProvider.ts, but when you import it, you are using leetCode.

src/leetcodePreviewProvider.ts

src/utils/webviewUtils.ts

src/shared.ts

Move the logic in webviewUtils.ts to leetCodePreviewProvider Fix missing semicolon Rename leetcodePreviewProvider to leetCodePreviewProvider

jdneo

LGTM. Thank you @xuzaixian for the great work!

Add Click the tree explorer should open the topic (LeetCode-OpenSourc…

dbeddab

…e#132)

jdneo self-requested a review March 6, 2019 10:48

Add Preview Function(LeetCode-OpenSource#132)

be596bd

xuzaixian force-pushed the master branch from e1ebd7c to be596bd Compare March 6, 2019 11:54

jdneo reviewed Mar 7, 2019

View reviewed changes