Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the icon in the activity bar #225

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Update the icon in the activity bar #225

merged 1 commit into from
Mar 21, 2019

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Mar 20, 2019

🎊 Now we have our own icons 🎊

Screen Shot 2019-03-20 at 8 47 58 PM

@jdneo jdneo requested review from poppinlp and Vigilans March 20, 2019 12:51
@jdneo jdneo added this to the 0.13.2 milestone Mar 20, 2019
@twchn
Copy link

twchn commented Mar 20, 2019

Amazing～ Who made this?

Vigilans
Vigilans approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@Vigilans Vigilans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The svg code is far reduced than previous version...

@poppinlp
Copy link
Contributor

WOW amazing!

@jdneo jdneo merged commit 5f895a2 into master Mar 21, 2019
@jdneo jdneo deleted the cs/icon branch March 21, 2019 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poppinlp poppinlp poppinlp approved these changes

@Vigilans Vigilans Vigilans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jdneo @twchn @poppinlp @Vigilans