Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement leetcode.filePath #380

Merged
merged 8 commits into from
Sep 10, 2019
Merged

implement leetcode.filePath #380

merged 8 commits into from
Sep 10, 2019

Conversation

magic-akari
Copy link
Contributor

No description provided.

@jdneo jdneo mentioned this pull request Aug 22, 2019
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jdneo
Copy link
Member

jdneo commented Sep 4, 2019

Hi @magic-akari,

Apologize for the late reply about this PR. I was busying with other stuff the days before. Today I just got a chance to take a look at it.

Very nicely implemented I think! Just some small questions. Would you mind to take a look?

Thanks

@jdneo jdneo added this to the 0.15.4 milestone Sep 4, 2019
@magic-akari
Copy link
Contributor Author

There are a lot of duplicate codes in leetcode.filePath config.
I have tried to use json schema's ref to reuse them, but it doesn't work in vscode.
Do you have any idea?

@jdneo
Copy link
Member

jdneo commented Sep 6, 2019

@magic-akari Yes, from engineering aspect, have the configuration clean and neat is a worth considering topic. While from the feature aspect, the changes here is good to go. Let me take a look at how to simplify the configuration in package.json this weekend.

If we cannot address it for now, we can create an issue to track that and ship this feature out to benefit our users first.

Thanks.

@jdneo jdneo merged commit 2d4266f into LeetCode-OpenSource:master Sep 10, 2019
@jdneo
Copy link
Member

jdneo commented Sep 10, 2019

Thank you @magic-akari! Nice work!

@jdneo jdneo changed the title implement leetcode.relativeFilePath implement leetcode.filePath Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants