Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New comment sort #5

Merged
merged 2 commits into from
Feb 18, 2021
Merged

New comment sort #5

merged 2 commits into from
Feb 18, 2021

Conversation

dessalines
Copy link
Member

No description provided.

@shilangyu
Copy link
Contributor

What does necro stand for here?

@dessalines
Copy link
Member Author

dessalines commented Feb 10, 2021 •
edited
Loading

It refers to necrobumping.

It was a common thing back in forum days for people to comment on dead forum threads, and because forum sorts just sort by Newest Comment, to push this really old thread to the top of everyone's feed. Many people would complain about this until reddits hot sorts came along.

The Lemmy Active sort is likewise smart enough to not push threads that are older than 2 days, but have new comments to the top of the feed.

Your front end can probably ignore both the newest_comment_time and newest_comment_time_necro fields, mine does at least for now. They're not necessary really, mainly useful for back-end sorting.

@dessalines dessalines merged commit 85f19d2 into main Feb 18, 2021
@dessalines dessalines deleted the new_comment_sort branch April 7, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dessalines @shilangyu