remove unnecessary hostname_ui config

config/defaults.hjson

@@ -102,9 +102,6 @@
   }
   # the domain name of your instance (mandatory)
   hostname: "unset"
-  # the domain name of your lemmy-ui instance used for OAUTH2 (defaults to the backend instance
-  # hostname)
-  hostname_ui: "example.com"
   # Address where lemmy should listen for incoming requests
   bind: "0.0.0.0"
   # Port where lemmy should listen for incoming requests

crates/api_crud/src/user/create.rs

@@ -247,13 +247,7 @@ pub async fn authenticate_with_oauth(
 
   // validate the redirect_uri
   let redirect_uri = &data.redirect_uri;
-  if !redirect_uri
-    .host_str()
-    .unwrap_or("")
-    .eq(context.settings().get_ui_hostname())
-    || !redirect_uri
-      .scheme()
-      .eq(context.settings().get_protocol_string())
+  if redirect_uri.host_str().unwrap_or("").is_empty()
     || !redirect_uri.path().eq(&String::from("/oauth/callback"))
     || !redirect_uri.query().unwrap_or("").is_empty()
   {

crates/utils/src/settings/mod.rs

@@ -74,13 +74,6 @@ impl Settings {
     fs::read_to_string(Self::get_config_location())
   }
 
-  pub fn get_ui_hostname(&self) -> &str {
-    match &self.hostname_ui {
-      Some(domain) => domain,
-      _ => &self.hostname,
-    }
-  }
-
   /// Returns either "http" or "https", depending on tls_enabled setting
   pub fn get_protocol_string(&self) -> &'static str {
     if self.tls_enabled {

crates/utils/src/settings/structs.rs

@@ -28,11 +28,6 @@ pub struct Settings {
   #[default("unset")]
   #[doku(example = "example.com")]
   pub hostname: String,
-  /// the domain name of your lemmy-ui instance used for OAUTH2 (defaults to the backend instance
-  /// hostname)
-  #[default(None)]
-  #[doku(example = "example.com")]
-  pub hostname_ui: Option<String>,
   /// Address where lemmy should listen for incoming requests
   #[default(IpAddr::V4(Ipv4Addr::new(0, 0, 0, 0)))]
   #[doku(as = "String")]