added cleanurl rules submodule #4906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-RedWizard
requested review from
Nutomic,
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
|
This is not complete, since it just adds an unused submodule. Feel free to press "ready for review" after changing the Rust code to utilize the data.min.json file. |
|
Yep of course just pulling this in isn't enough, and also it would be better if this were an external rust crate, that could be used by other projects also. I made a lemmy post about this here: https://lemmy.ml/post/18162485 If you don't plan on completing that, I think we should just close this as its not enough. |
|
We'll eventually use @jendrikw 's https://github.com/jendrikw/clearurls library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for issue #4905