Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inheritance principle: Include enumeration indices in source #2

Open
wants to merge 2 commits into
base: rewrite_inheritance_principle
Choose a base branch
from

Conversation

Lestropie
Copy link
Owner

Testing to see whether or not including enumeration indices in the source code as proposed here does or does not result in a CI complaint about formatting.

Copy link

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to give a try if it would work to disable "one" ordering check for the block following https://github.com/remarkjs/remark-lint#ignore-warnings

src/02-common-principles.md Show resolved Hide resolved
src/02-common-principles.md Show resolved Hide resolved
@Lestropie
Copy link
Owner Author

Works; but I'll defer to maintainers the conversation around whether or not this is something you want to permit / permit in this fashion / permit everywhere.

(Personally: I see no point in enumerating unless you intend on referring to a specific entry; if that's not the case, they should be bullet points instead. I'd almost prefer that appropriate enumeration in code be enforced, since if the entries / order changes, the rest of the source needs to be checked for cross-references)

@sappelhoff
Copy link

Would this also lead to a rendering of list items as 5.1.2 instead of 5.a.ii? The latter is what we currently have in the PR. see also bids-standard#946 (comment)

Lestropie pushed a commit that referenced this pull request Apr 26, 2024
…ids-standard#1299)

* Pet recon method tweaks (#2)

* add conditionals for ReconMethod Metadata

* add min and max values to scatter fraction

* add conditional for ReconFilterSize

* Apply suggestions from code review

* Update pet.yaml

* use intersects for 'none' check, switch to recommended

* Apply suggestions from code review

Co-authored-by: Chris Markiewicz <[email protected]>

Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Stefan Appelhoff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants