updated Dice.php line 233, because __toString deprecated in PHP 7.4.1… #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, must be getName
|
ReflectionType::__toString() in PHP 7.4.1 deprecated per |
|
I'll have to check which version getName was added in. I changed it from that to toString in an earlier commit because getName was only supported in the newest php versions at a time. Hopefully the depreciation means that getName is available in all supported php versions. |
|
Is there a planned time frame for when this issue (i.e., issue #177) will be addressed? |
|
This couldn't be automatically merged due to the pull coming from an earlier branch so I haven't merged it. I had also recently come across a bug when using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, must be getName