Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where 'shareInstances' resolve but fail to propagate #201

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Fix issue where 'shareInstances' resolve but fail to propagate #201

merged 2 commits into from
Mar 28, 2022

Commits on Mar 17, 2022

  1. Level-2#200 - Expand shareInstances test to replicate propagation issue

    @lkrms
    lkrms committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    de4b3e5 View commit details
    Browse the repository at this point in the history

  2. Level-2#200 - Fix issue where 'shareInstances' resolve but fail to pr… 

    …opagate

Because `$share` is passed by reference to `matchParam()`, and
`matchParam()` removes matching objects from its `$search` array,
instances may be removed from `$share` before it is passed to `expand()`
or `create()`. Depending on the order of constructor parameters and the
relative placement of `shareInstances` dependencies in the object tree,
this may result in multiple instances of these dependencies being
created.

Fixed by passing a copy of the `$share` array to `matchParam()`.
    @lkrms
    lkrms committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    e4581e5 View commit details
    Browse the repository at this point in the history