Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default testCommon parameter #264

Closed
ralphtheninja opened this issue Jul 11, 2018 · 1 comment
Closed

Remove default testCommon parameter #264

ralphtheninja opened this issue Jul 11, 2018 · 1 comment
Milestone
v6

Comments

@ralphtheninja
Copy link
Member

Previously we often just used testCommon.js from abstract-leveldown and passed it in to abstract tests and it made sense at the time to make it a default parameter, e.g.

module.exports.all = function (test, testCommon) {
  testCommon = testCommon || require('./common')
  // ..
}

This doesn't really make much sense now since all implementations are forced to pass in their own testCommon due to factory function etc.
@ralphtheninja ralphtheninja added this to the v6 milestone Jul 11, 2018
@ralphtheninja ralphtheninja changed the title Remove default testCommon Remove default testCommon parameter Jul 12, 2018
@ralphtheninja ralphtheninja mentioned this issue Jul 13, 2018
Merged
vweevers added a commit that referenced this issue Jul 13, 2018
@vweevers
remove default testCommon parameter (#264)
b21bda9
vweevers added a commit that referenced this issue Jul 13, 2018
@vweevers
remove default testCommon parameter (#264)
3346424
vweevers added a commit that referenced this issue Jul 13, 2018
@vweevers
Export test suite as single function (#271)
16ba24e 
* poc: export test suite as single function

* separate openAdvanced tests

* test setUp and tearDown of open tests

* alternative: merge test, testCommon, factory into single options object

* move handling of test options to test/common.js

* remove default testCommon parameter (#264)

* move test.js to test/self.js
@ralphtheninja
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6
Development

No branches or pull requests
1 participant
@ralphtheninja