Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #234. I copied over the
seek
function fromleveldown
, but without the type checks (because that's up to the implementation).Can be released as a minor because AFAIK
leveldown
is the only implementation that supports seeking atm, and it does so by definingseek
rather than_seek
, so effectively there's no change.When this lands in
leveldown
and we rename itsseek
to_seek
, there's one change: the seek target will be serialized. That's fine, becauseleveldown
can only seek to Buffer or strings anyway. It can only be considered a breaking change if someone doesseek(3)
and is expecting it to throw.Next step is to copy over tests from
leveldown
, but I prefer to first land it inleveldown
and see that its current tests pass.cc @peakji