Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iterator.seek #237

Merged
merged 1 commit into from
Jun 17, 2018
Merged

Add iterator.seek #237

merged 1 commit into from
Jun 17, 2018

Conversation

vweevers
Copy link
Member

Closes #234. I copied over the seek function from leveldown, but without the type checks (because that's up to the implementation).

Can be released as a minor because AFAIK leveldown is the only implementation that supports seeking atm, and it does so by defining seek rather than _seek, so effectively there's no change.

When this lands in leveldown and we rename its seek to _seek, there's one change: the seek target will be serialized. That's fine, because leveldown can only seek to Buffer or strings anyway. It can only be considered a breaking change if someone does seek(3) and is expecting it to throw.

Next step is to copy over tests from leveldown, but I prefer to first land it in leveldown and see that its current tests pass.

cc @peakji

@vweevers vweevers merged commit d806bf1 into master Jun 17, 2018
@vweevers vweevers deleted the add-iterator-seek branch June 17, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants