-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for for await...of db.iterator()
#91
Labels
test
Improvements or additions to tests
Comments
vweevers
added a commit
that referenced
this issue
Sep 28, 2021
In other states (besides 'open') a 'Database is not open' error is now thrown. This reduces the scope of `deferred-leveldown` to what's strictly needed in `levelup` and aligns behavior. In addition, override public methods of `abstract-leveldown` instead of private methods. This has one downside: they need to do the same callback to promise conversion that `abstract-leveldown` does. The upside is that operation callbacks are not called before the db has finished opening, including in cases where `abstract-leveldown` has a fast-path, like on `db.batch([])` which because the array is empty bypasses `_batch()`. Closes #91 Closes #90
vweevers
added a commit
that referenced
this issue
Sep 28, 2021
In other states (besides 'open') a 'Database is not open' error is now thrown. This reduces the scope of `deferred-leveldown` to what's strictly needed in `levelup` and aligns behavior. In addition, override public methods of `abstract-leveldown` instead of private methods. This has one downside: they need to do the same callback to promise conversion that `abstract-leveldown` does. The upside is that operation callbacks are not called before the db has finished opening, including in cases where `abstract-leveldown` has a fast-path, like on `db.batch([])` which because the array is empty bypasses `_batch()`. Closes #91 Closes #90
Merged
vweevers
added a commit
that referenced
this issue
Sep 30, 2021
In other states (besides 'open') a 'Database is not open' error is now thrown. This reduces the scope of `deferred-leveldown` to what's strictly needed in `levelup` and aligns behavior. In addition, override public methods of `abstract-leveldown` instead of private methods. This has one downside: they need to do the same callback to promise conversion that `abstract-leveldown` does. The upside is that operation callbacks are not called before the db has finished opening, including in cases where `abstract-leveldown` has a fast-path, like on `db.batch([])` which because the array is empty bypasses `_batch()`. Closes #91 Closes #90
vweevers
added a commit
that referenced
this issue
Sep 30, 2021
In other states (besides 'open') a 'Database is not open' error is now thrown. This reduces the scope of `deferred-leveldown` to what's strictly needed in `levelup` and aligns behavior. In addition, override public methods of `abstract-leveldown` instead of private methods. This has one downside: they need to do the same callback to promise conversion that `abstract-leveldown` does. The upside is that operation callbacks are not called before the db has finished opening, including in cases where `abstract-leveldown` has a fast-path, like on `db.batch([])` which because the array is empty bypasses `_batch()`. Closes #91 Closes #90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Added in Level/abstract-leveldown#379. Needs tests here.
The text was updated successfully, but these errors were encountered: