Separate tests into node and browser + airtap + levelup integration tests #47
Conversation
|
Will need proper setup of sauce labs before adding |
test-browser.js
Outdated
| skipRepairTest: true, | ||
| skipErrorIfExistsTest: true, | ||
| skipDestroyTest: true | ||
| }) |
There was a problem hiding this comment.
This code came from test.js, but using level-packager/abstract/test instead.
| }) | ||
| }) | ||
|
|
||
| test('teardown', testCommon.tearDown) |
There was a problem hiding this comment.
The rest was copied over from level-js/test/levelup-test.js
|
I didn't see where you were going at first. It's coming together now :) Nice work |
Aye, sorry. Not always easy to convey what's in your head. I've been thinking about this some more and I'll continue on |
ralphtheninja
changed the title
|
Waiting for a new minor on |
ralphtheninja
changed the title
|
@ralphtheninja can you explain the I must be missing something: if |
|
It's used here https://github.com/Level/mem/blob/master/test.js#L5 |
If the db is persistent (i.e. not memdown), the values are in the db when it's closed. So no need to batch the data. This is what I meant by that the tests are not independent. E.g. previous tests write |
|
@vweevers Are you cool with the latest two commits after your review? |
No description provided.