Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump leveldown to ~1.0 #13

Closed
wants to merge 1 commit into from
Closed

bump leveldown to ~1.0 #13

wants to merge 1 commit into from

Conversation

duralog
Copy link

@duralog duralog commented Nov 14, 2014

if you bump the version, node-0.11.x users can install...

should be 1.0 anyway...

cheers

@kesla
Copy link

kesla commented Nov 14, 2014

leveldown 1.0 introduces some new features (support for empty values most notably) that we don't have support for in the current version of levelup (but we're working on it (Level/levelup#289) ).

That's why level doesn't depend on leveldown 1.0 yet.

@kesla kesla closed this Nov 14, 2014
@duralog
Copy link
Author

duralog commented Nov 15, 2014

ah, I see... cool. thanks

@heapwolf
Copy link

heapwolf commented Dec 5, 2014

It shouldn't mater if leveldown has new features as long as they don't impact levelup. The only impact on levelup in the next release is that we are removing writestream(). If I'm right, It seems like we shouldn't be waiting to bump the leveldown dependency. I've also been out of the loop for a while so feel free to correct me if I'm wrong /cc @dominictarr @rvagg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants