Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog and upgrade guide #512

Closed
vweevers opened this issue Oct 20, 2018 · 3 comments
Closed

Update changelog and upgrade guide #512

vweevers opened this issue Oct 20, 2018 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@vweevers
Copy link
Member

@ralphtheninja should we:

  1. Only link to the abstract-leveldown upgrade guide
  2. Copy relevant parts (seeking, rejecting nullish values, serialization of range options, ..)

I'm leaning towards 2, because a large chunk of the abstract-leveldown upgrade guide is about tests.

Also, is there anything else you want to include in the new leveldown major?

@vweevers vweevers mentioned this issue Oct 20, 2018
@ralphtheninja
Copy link
Member

I'm leaning towards 2, because a large chunk of the abstract-leveldown upgrade guide is about tests.

Sounds good to me.

Also, is there anything else you want to include in the new leveldown major?

Not that I can think of. Good work!

@vweevers
Copy link
Member Author

vweevers commented Oct 20, 2018

Picking some low hanging fruit:

@vweevers vweevers added the documentation Improvements or additions to documentation label Dec 9, 2018
@vweevers vweevers added this to the 5.0.0-rc1 milestone Dec 15, 2018
@vweevers vweevers self-assigned this Dec 15, 2018
@vweevers
Copy link
Member Author

For reference, I'm excluding the following items from the changelog:

As nan is gone and the prebuild things will be replaced by prebuildify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants