Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sync test #300

Merged
merged 2 commits into from
Jul 15, 2018
Merged

Remove sync test #300

merged 2 commits into from
Jul 15, 2018

Conversation

ralphtheninja
Copy link
Member

Closes #285

@ralphtheninja ralphtheninja merged commit aeabe99 into master Jul 15, 2018
@ralphtheninja ralphtheninja deleted the remove-sync-test branch July 15, 2018 20:25
@vweevers
Copy link
Member

@ralphtheninja reading Level/leveldown#157 and the PR that introduced these sync tests (#58), I now understand they were about triggering segfaults. I just tested it on latest leveldown, still segfaults. So I'll add the test to leveldown instead, but skip it, and add a comment with some background.

This was referenced Oct 20, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphtheninja @vweevers