Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update leveldb to 1.17.0 #107

Closed
wants to merge 1 commit into from
Closed

update leveldb to 1.17.0 #107

wants to merge 1 commit into from

Conversation

kesla
Copy link
Contributor

@kesla kesla commented Jun 13, 2014

No description provided.

@juliangruber
Copy link
Member

sweet, do you know what changed roughly?

@kesla
Copy link
Contributor Author

kesla commented Jun 13, 2014

@juliangruber Good thing you asked,

1.16 & 1.17 seem to fix bugs, while 1.15 includes changes to writing (moving from mmap to stdio-based) and a different behaviour when there's a compatction error (putting the db in a read-only state)

Here's the commits for v 1.15, 1.16 and 1.17 respectively:
https://code.google.com/p/leveldb/source/detail?r=0cfb990d58ffba9b56df6e9829ddb9d220824066
https://code.google.com/p/leveldb/source/detail?r=269fc6ca9416129248db5ca57050cd5d39d177c8
https://code.google.com/p/leveldb/source/detail?r=e353fbc7ea81f12a5694991b708f8f45343594b1

@kesla
Copy link
Contributor Author

kesla commented Jun 13, 2014

oh! And support for iOS...

@juliangruber
Copy link
Member

cool, especially the mmap one is relevant, iirc we patched that in place

@kesla
Copy link
Contributor Author

kesla commented Jun 13, 2014

however, I guess that this should be rebased against #91, since that already include an update of leveldb to 0.15.0

@rvagg
Copy link
Member

rvagg commented Jun 13, 2014

@kesla yes, please do the PR against 0.11-wip and we'll tidy it up and shipit, been sitting on this too long so we'll call it a day on the things we're waiting on and push them back to a later release

@kesla
Copy link
Contributor Author

kesla commented Jun 14, 2014

I've added the commit updating leveldb to the 0.11-wip-branch instead.

@kesla kesla closed this Jun 14, 2014
@kesla kesla deleted the leveldb-1.17 branch June 14, 2014 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants