Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to nan 1.2.0 #115

Closed
wants to merge 1 commit into from
Closed

update to nan 1.2.0 #115

wants to merge 1 commit into from

Conversation

andrewrk
Copy link
Contributor

No description provided.

@andrewrk
Copy link
Contributor Author

Tests are passing. Looks like 0.8 travis ci is failing due to the ^ in package.json. Shall I replace those with 0.x.x, 1.x.x etc?

@juliangruber
Copy link
Member

can you rebase this against #91, the current pr for the next release?

@andrewrk
Copy link
Contributor Author

Oops. Didn't see #91 before I made this. Looks like after rebasing the diff is practically empty.

@andrewrk andrewrk closed this Jun 30, 2014
@kesla
Copy link
Contributor

kesla commented Jun 30, 2014

practically empty - that's still something that would be aweosme to get into #91! @andrewrk would you be interested in creating a new PR against #91 that updates the nan-version?

@andrewrk
Copy link
Contributor Author

Sure.

@andrewrk
Copy link
Contributor Author

ok, so when I said practically empty...

diff --git a/package.json b/package.json
index c908e9e..8b8a05d 100644
--- a/package.json
+++ b/package.json
@@ -29,7 +29,7 @@
   "main": "index.js",
   "dependencies": {
     "bindings": "~1.2.0",
-    "nan": "~1.1.0"
+    "nan": "~1.2.0"
   },
   "devDependencies": {
     "tap": "~0.4.8",

This is trivial. I don't think you need a pull request from me :-)

@kesla
Copy link
Contributor

kesla commented Jun 30, 2014

#91 now has nan 1.2.0, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants