Fixes https://github.com/Level/leveldown/issues/196

[obastemur]

No description provided.

[ralphtheninja]

+1

@No9 You're the go to guy when it comes to windows :)

[No9]

I can test it tomorrow but won't this break on 2013 as that version needs the 'port/win' folder?
Also does this now mandate that the --msvs_version has to be passed as part of the build?
If so this will cause issues with down stream libs that depend on this and we should at least have to warn the user that --msvc_version is mandatory on windows somewhere in the output?

@obastemur I also noted here #213 (comment) that there is a patch to go into /deps/leveldb/port-libuv/port_uv.h

Did you come across that?

Thanks for trying to land this in as I couldn't come up we an alternative to the --msvs_version approach when I looked at this back in September so we might just have to take the hit

It also looks like this commit 29282aa from @appelgriebsch is trying to fix the same issue. I seem to remember that the approach in that commit of remming out stdint.h still caused issues on 2015 as the 2015 build defaulted to that file hence the need to ignore it as outlined by @obastemur here.

So I think the steps are

1. Rollback https://github.com/Level/leveldown/blob/29282aa1de6917da110b116feee4c28f879435a7/deps/leveldb/leveldb-1.18.0/port/win/stdint.h but keep https://github.com/Level/leveldown/blob/29282aa1de6917da110b116feee4c28f879435a7/deps/leveldb/port-libuv/port_uv.h
2. Confirm the MSVS_VERSION != "2013" test in this patch
3. Decide if we are going to take the hit of the build option

[obastemur]

Also does this now mandate that the --msvs_version has to be passed as part of the build?

No. MSVS_VERSION is defined by gyp based on whatever version of VS is selected by gyp etc..

@obastemur I also noted here #213 (comment) that there is a patch to go into /deps/leveldb/port-libuv/port_uv.h
Did you come across that?

Actually I've changed a lot for UWP / VS2015 (see Level/leveldown-mobile) but the original issue is just because of stdint.h so the rest (if there is any) might be subject to another PR.

It also looks like this commit 29282aa from @appelgriebsch is trying to fix the same issue.

IMHO that's not a solution. (shadowing stdint.h)

I've confirmed VS2013. (Don't know VS2012 so didn't add here)

[No9]

OK @obastemur
Agreed "shadowing stdint.h" is not a solution
As it wasn't introduced by this patch I think we should merge this and deal with that as a separate issue.
Sorry for holding up the show but I wanted to be sure.
👍
And thanks again @obastemur for this patch
windows support is very important and your expertise really is appreciated. :)

[No9]

@ralphtheninja do you want to do the honours with the merge
As it's build I don't think we need to push a release for this

[obastemur]

@No9 Thanks :)

[ralphtheninja]

@ralphtheninja do you want to do the honours with the merge
As it's build I don't think we need to push a release for this

Nope! I want you do do it :)