Tweak changelog #483
Merged
Tweak changelog #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's looking pretty neat now with links to users etc. We should probably do this in all repositories. |
vweevers
reviewed
Jun 11, 2018
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
| * Fix build problems on windows https://github.com/Level/leveldown/issues/247 (@obastemur) | ||
|
|
||
| - Fix build problems on windows [Level#247](https://github.com/Level/leveldown/issues/247) ([**@obastemur**](https://github.com/obastemur)) |
There was a problem hiding this comment.
Missing parentheses around issue
vweevers
reviewed
Jun 11, 2018
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
| * Fix build problems on windows https://github.com/Level/leveldown/issues/196 (@obastemur) | ||
|
|
||
| - Fix build problems on windows [Level#196](https://github.com/Level/leveldown/issues/196) ([**@obastemur**](https://github.com/obastemur)) |
There was a problem hiding this comment.
Missing parentheses around issue
|
This is very nice indeed! I love remark :) |
ralphtheninja
force-pushed
the
tweak-changelog
branch
from
4a8d830
to
93930cc
Compare
ralphtheninja
commented
Jun 11, 2018
CHANGELOG.md
Outdated
| @@ -289,7 +289,7 @@ | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Fix build problems on windows [Level#247](https://github.com/Level/leveldown/issues/247) ([**@obastemur**](https://github.com/obastemur)) | |||
There was a problem hiding this comment.
The reason I missed these is because they were plain urls and not in the #NR format.
vweevers
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #431
Direct link to this
CHANGELOG.mdhttps://github.com/Level/leveldown/blob/tweak-changelog/CHANGELOG.md