Remove node 6, use prebuildify fork for now, build on node 8 #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphtheninja
commented
Dec 16, 2018
ralphtheninja
commented
Dec 16, 2018
ralphtheninja
commented
Dec 16, 2018
vweevers
approved these changes
Dec 16, 2018
|
I'll let appveyor finish up before merging. |
|
And also needs rebasing ;) |
|
Looks like we got some error on appveyor even though the build passed
|
ralphtheninja
force-pushed
the
prebuildify-tweaks
branch
from
387e6b9
to
ecb9e53
Compare
|
Just checked old sodium-native setup on appveyor and it shows similar output:
From https://ci.appveyor.com/project/mafintosh/sodium-native/builds/20896258/job/ql6fno6kfrwi3rs2 We don't get the yellow output though on leveldown. |
|
Merged too early, current got canceled on appveyor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #553 (comment)