Add script to test prebuilds in various docker images #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
commented
Oct 4, 2019
| @@ -9,7 +9,8 @@ | |||
| "test": "standard && (nyc -s tape test/*-test.js | faucet) && nyc report", | |||
| "test-gc": "npx -n=--expose-gc tape test/{cleanup,iterator-gc,chained-batch-gc}*-test.js", | |||
| "test-electron": "electron test/electron.js", | |||
| "test-prebuild": "cross-env PREBUILDS_ONLY=1 npm t", | |||
| "test-prebuild": "cross-env PREBUILDS_ONLY=1 tape test/*-test.js | faucet", | |||
There was a problem hiding this comment.
Skipping standard and nyc because standard hits some permission issue, and without these we can use a readonly volume ($(pwd):/app:ro).
vweevers
commented
Oct 4, 2019
| @@ -9,7 +9,8 @@ | |||
| "test": "standard && (nyc -s tape test/*-test.js | faucet) && nyc report", | |||
| "test-gc": "npx -n=--expose-gc tape test/{cleanup,iterator-gc,chained-batch-gc}*-test.js", | |||
| "test-electron": "electron test/electron.js", | |||
| "test-prebuild": "cross-env PREBUILDS_ONLY=1 npm t", | |||
| "test-prebuild": "cross-env PREBUILDS_ONLY=1 tape test/*-test.js | faucet", | |||
| "test-prebuilds": "cross-env MSYS_NO_PATHCONV=1 bash ./scripts/test-prebuilds", | |||
There was a problem hiding this comment.
The MSYS_NO_PATHCONV=1 is a workaround for Windows, when using docker machine & git bash.
|
Won't use this that often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help with #675. They all pass, btw.