Remove ws, update #309
Remove ws, update #309
Conversation
|
Let me know if there is there anything else that should be added or needs tidying up before this can be merged. |
|
Ping @jcrugzz |
|
Sorry! Got caught up this past couple days. Ill add my thoughts :). Thanks for spearheading this through! |
|
|
||
| TODO: talk about performance and multiple writeStream implementations | ||
| Also, check out the [modules page](https://github.com/rvagg/node-levelup/wiki/Modules) in the wiki for examples on write stream modules in userland. |
There was a problem hiding this comment.
We should add a specific write-streams section to link to directly to make it a bit easier.
There was a problem hiding this comment.
Yeap sounds good. I thought about it yesterday, but since we don't have any section like that I threw in a more generic link for now.
add links to issue page discussion the removal and also link to the wiki where more information on alternative userland write stream approaches can be found
|
@jcrugzz @mcollina Updated README based on your feedback and also added |
|
@ralphtheninja LGTM 👍 |
|
@jcrugzz Aaah you added some stuff to the wiki. Sweet! :) |
|
@ralphtheninja yes indeed! :) |
|
LGTM Il giorno gio 12 mar 2015 alle ore 16:56 Jarrett Cruger <
|
I cleaned up some stuff and added some links in README to point to the discussion behind the removal and also a link to the wiki page.