Drop legacy features & runtime environments #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using `queueMicrotask()` in browsers, for a consistent experience regardless of bundler (and of runtime in the future, when we drop node 10). Webpack no longer shims node core modules. In theory bundlers can now skip shimming `process`, were it not for our `readable-stream` dependency which uses `process.nextTick()` at the time of writing and has more reason to keep doing so. In modules where the risk of timing issues (due to not having a common microtask scheduler between modules) is low, like here in `levelup`, I prefer the idiomatic `queueMicroTask()` function. Lastly, maybe streams are not here to stay. Async iterators are coming to the level ecosystem. Or maybe we'll switch to `streamx` which is planning to use `queueMicrotask()` as well.
In favor of Batch.db which matches the property on abstract-leveldown's chained batch interface. Unlikely to cause breakage because _levelup was a private and undocumented property.
vweevers
added
maintenance
This was referenced Apr 11, 2021
|
Chrome on Android 10 failed, but Android 6-9 and 11 did not, so I think we can skip Android 10 for now and look into it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref Level/community#98.
Blocked by release of Level/deferred-leveldown#86, otherwise ready for review (assuming tests pass on Sauce Labs).