httpd: allow websockets VNC connection on http port if run with -enablehttpproxy #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream noVNC defaults to connecting on the http port instead
of port 5900 and it would be nice if that would just work.
- If run with -enablehttpproxy allow http connection to be
upgraded to websockets.
- Also exports the new rfbNewWebSocketsClient() function in case
anybody is using a custom webserver implementation in their
application, instead of the libvncserver one, and also wants
libvcnserver to handle the websockets connection.
You need to feed it the http request headers that were
already read from the socket by the webserver.
To test (on Debian or its derivates):
==
sudo apt install novnc
sudo ln -sf vnc_lite.html /usr/share/novnc/index.vnc
sudo x11vnc -httpport 80 -enablehttpproxy \
-httpdir /usr/share/novnc -no6 -xkb -repeat -auth guess \
-display WAIT:0 -forever -shared
==
Go with web browser to IP, and it should work without having to
patch novnc or change settings.
Signed-off-by: Floris Bos <[email protected]>
|
A lot of changes to the guts, this will need a lot of testing for regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream noVNC defaults to making the VNC websockets connection on the http port instead of port 5900 and it would be nice if that would just work.
If run with -enablehttpproxy allow http connection to be upgraded to websockets.
To test (on Debian or its derivates):
Go with web browser to IP, and it should work without having to
patch novnc or change settings.