Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSL by default with MUMPS fallback. Ipopt 3.13.0 #37

Merged
merged 17 commits into from
Dec 2, 2019
Merged

HSL by default with MUMPS fallback. Ipopt 3.13.0 #37

merged 17 commits into from
Dec 2, 2019

Conversation

Libbum
Copy link
Owner

@Libbum Libbum commented Nov 30, 2019

Closes #35 #36 and possibly #34 once documentation is done.

  • Implement capacity
  • Document
  • Coverage
  • Discuss issue closing or additional information in each.

@codecov
Copy link

codecov bot commented Dec 1, 2019

Codecov Report

Merging #37 into master will decrease coverage by 1.16%.
The diff coverage is 72.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage     100%   98.83%   -1.17%     
==========================================
  Files          15       15              
  Lines         908      942      +34     
==========================================
+ Hits          908      931      +23     
- Misses          0       11      +11
Impacted Files Coverage Δ
src/2013RVanilla.jl 100% <100%> (ø) ⬆️
src/Abstractions.jl 100% <100%> (ø) ⬆️
src/2013RRockyRoad.jl 100% <100%> (ø) ⬆️
src/DICE.jl 69.56% <63.15%> (-30.44%) ⬇️
src/2016R2.jl 98.75% <66.66%> (-1.25%) ⬇️
src/2016R.jl 98.73% <71.42%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cfae32...b37ff8b. Read the comment docs.

@Libbum
Copy link
Owner Author

Libbum commented Dec 1, 2019

Hmm. Seems that if you test for ma27 this system works if libcoinhsl doesn't exist on a machine but ma97 essentially coredumps. Damnit.

@Libbum
Copy link
Owner Author

Libbum commented Dec 1, 2019

Oh, come on. Now the ma27 check is failing?

@Libbum
Copy link
Owner Author

Libbum commented Dec 1, 2019

OK, now it's doc etc time.

@Libbum
Copy link
Owner Author

Libbum commented Dec 1, 2019

Coverage drop I'm fine with. We're not going to get Travis to check HSL.

@Libbum Libbum merged commit 8c84450 into master Dec 2, 2019
@Libbum Libbum deleted the hsl branch December 2, 2019 15:05
@Libbum Libbum mentioned this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests on Ipopt 3.13
1 participant