-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/allow ensemble dir overwrite #1041
Conversation
Name of option? We should remove appending of worker ID to each sim_dir so they don't get re-run under different worker and produce another dir. It is not "overwriting" a sim_dir, but overwriting input files. |
…low_dir fucntionality test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions:
- Modify top comment on PR (remove "allow_dir_overwrite")
also add separating log files to workflow dirs to bullet list - as there are multiple features here
- In ensemble dir exists message - add use
libE_specs["reuse_ensemble_dir"] = True
to allow reuse of dir. - created dirs like test_workflow0_nworkers3_comms-local/ need to be cleaned in run_scripts.sh
I think we also need to make reuse_ensemble_dir work when there is a named workflow dir as this is how Optimas now runs.
ie. if you add libE_specs["reuse_ensemble_dir"] = True
to test_workflow_dir.py it wont rerun. This could be incorporated into the test with 2 libE() calls.
User can set
libE_specs["reuse_output_dir"]
to prevent intentional errors and warnings on attempting to reuse an ensemble directory.Keep in mind "overwriting" a sim_dir with a new one really means deleting old copied and symlinked files over.
Another consequence of this approach and the current sim/gen-dir naming scheme is if subsequent runs overwrite the same ensemble directory, but different workers each time process the same sim_id, then both sim_dirs for that sim_id will be retained.
"reuse_ensemble_dir"
libE_specs["reuse_output_dir"] = True
to allow subsequent runs to operate within a previous ensemble directoryAddresses #1028 and #1027