Release/v 1.0.0 #1090
Merged
Release/v 1.0.0 #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildsm
reviewed
Sep 22, 2023
period.
Minor grammar and style
Minor grammar and consistency
Several minor changes for grammar and clarity
Edits for clarity
consistent casing
minor edits
minimizing like
Minor clarifications
minor edits
Minor edits
format
Attempting to make some links more accessible.
jmlarson1
reviewed
Sep 22, 2023
jmlarson1
reviewed
Sep 22, 2023
Fixes/into v1.0 release
jmlarson1
reviewed
Sep 22, 2023
| ) | ||
|
|
||
| os.remove(file) | ||
| # with open(file, "r") as f: |
There was a problem hiding this comment.
Did we want this commented out on purpose?
jmlarson1
reviewed
Sep 22, 2023
jlnav
approved these changes
Sep 22, 2023
jmlarson1
reviewed
Sep 22, 2023
|
|
||
| assert mgr_comm.running, "Should still be running" | ||
| mgr_comm.send("Done") | ||
| # def ignore_handler(signum, frame): |
There was a problem hiding this comment.
This is the test we removed that is problematic on CI (macOS in virtual env). We could remove it.
There was a problem hiding this comment.
We could remove, or at least add a note to the source code about why it's commented out
jmlarson1
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1008