[WIP] Asktell/variables objectives #1448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlnav
changed the title
…tandard-variables
… lb and gen_specs.out
…ith aposmm in unit test
…iables_objectives
…end objective keys to the internal dtype
…ss; setting up unit test to eventually map user-specififed variables into internal xs
… fs need to be figured out reasonably, somehow, still
…on't want to convert. fix key-that-starts-with-variable condition, plus append the distinguishing integer
…, since variables/objectives probably wont be passed in. remove exact H-entry test, since the gen does its own internal persis_info
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## experimental/jlnav_plus_shuds_asktell #1448 +/- ##
==========================================================================
+ Coverage 78.78% 90.93% +12.14%
==========================================================================
Files 81 80 -1
Lines 8085 8086 +1
Branches 1423 1434 +11
==========================================================================
+ Hits 6370 7353 +983
+ Misses 1506 555 -951
+ Partials 209 178 -31 ☔ View full report in Codecov by Sentry. |
…f-concepts from before we became dedicated to ask/tell, plus currently it's gen_out is rather "largely dimensioned" for defining via variables/objectives
…ss; so we know which variables refer to which internal 'x'-like fields
…iables_objectives
…ut into list_dicts_to_np now, to unpack the opposite direction
…ict->np converters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing specifying
variablesandobjectivesto ask/tell generators, This basically supersedes specifying gen_specs.in or gen_specs.out from the user's perspective.