A fix inappropriate module name #1611
Conversation
|
Can you remove the other secure message below? sounds redundant |
|
Ok i will remove that
…On Wed, 10 Jun 2020 at 04:05, muarachmann ***@***.***> wrote:
Can you remove the other secure message below? sounds redundant
[image: Screen Shot 2020-06-10 at 4 04 41 AM]
<https://user-images.githubusercontent.com/16350814/84222491-a025b780-aacf-11ea-9623-b5bd33ed21ee.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1611 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQABPACXBQRXCLDOZVSATDRV32AZANCNFSM4NIZQZOA>
.
|
|
@ahanipeitra1994 By default, the tab title shows within the tab, which is why "Secure Message" shows underneath the tab title. Since the module already has a name ("Patient Messaging"), I would make that the title and move that piece of code up into where you added a title, so the tab name will become "Patient Messaging" and logo + title within the tab will display the way it's currently being displayed. |
|
Works fine now. @maggienegm the previous format is kind of obsolete with majority of the web using HTML5. |
| @@ -86,7 +86,7 @@ function getAuthPortalUsers() | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <head> | |||
| <meta http-equiv="content-type" content="text/html; charset=UTF-8"> | |||
| <!-- <meta http-equiv="content-type" content="text/html; charset=UTF-8"> --> | |||
There was a problem hiding this comment.
This comment is not necessary, remove it.
| @@ -86,7 +86,7 @@ function getAuthPortalUsers() | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <head> | |||
| <!-- <meta http-equiv="content-type" content="text/html; charset=UTF-8"> --> | |||
| <meta http-equiv="content-type" content="text/html; charset=UTF-8"> | |||
There was a problem hiding this comment.
I asked to remove the comment, not uncomment it.
| <body class="body_top"> | ||
| <div class='title'> | ||
| <h2><img style='width:25%;height:auto;' class='logo' src='<?php echo $GLOBALS['images_path']; ?>/logo-full-con.png'/> <?php echo xlt('Patient Messaging'); ?></h2> | ||
| </div> |
There was a problem hiding this comment.
@ahanipeitra1994 it looks like with your last commit, you removed the solution you pushed earlier and it's back to the original code, so now the issue exists again. Make sure to always test before you push!
ahanipeitra1994
force-pushed
the
Inappropriate_module_name
branch
from
95fe5f7
to
9901b71
Compare
|
Tested and LGTM. @Ngai-E and @muarachmann ? |
| @@ -111,6 +110,9 @@ function getAuthPortalUsers() | |||
|
|
|||
| </head> | |||
| <body ><!-- style='background:#f1f2f7;' --> | |||
| <div class='title container'> | |||
| <h2><img style='width:25%;height:auto; class='logo' src='<?php echo $GLOBALS['images_path']; ?>/logo-full-con.png'/> <?php echo xlt('Patient Messaging'); ?></h2> | |||
| </div> | |||
There was a problem hiding this comment.
I think it should be patient portal
|
Ok thanks I will change it
…On Sat, Sep 5, 2020, 9:46 AM Mua Rachmann ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In patient_portal/messaging/messages.php
<#1611 (comment)>:
> @@ -111,6 +110,9 @@ function getAuthPortalUsers()
</head>
<body ><!-- style='background:#f1f2f7;' -->
+<div class='title container'>
+ <h2><img style='width:25%;height:auto; class='logo' src='<?php echo $GLOBALS['images_path']; ?>/logo-full-con.png'/> <?php echo xlt('Patient Messaging'); ?></h2>
+ </div>
I think it should be patient portal
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1611 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQABPGURKGNYB4ZTEZAL53SEH3F3ANCNFSM4NIZQZOA>
.
|
I did a fix on the issue #1459.
