Fix in Patient Issues Showing Incorrect Date When left Blank #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahanipeitra1994
changed the title
please can you send us a screenshot of the fix. |
|
ok let me do that now
…On Fri, 19 Jun 2020 at 09:24, Ngai Elizabeth ***@***.***> wrote:
This is a fix in issue #1555
<#1555>. The Patient
'Issues' now does not display incorrect date without entry.
please can you send us a screenshot of the fix.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1617 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQABPC2ETOXDBH5J3AFB5DRXMODBANCNFSM4OCPY3NQ>
.
|
|
This is after the fix. The beginning and end date does not show again
unless the field is entered.
…On Fri, 19 Jun 2020 at 09:40, ahani peitra ***@***.***> wrote:
ok let me do that now
On Fri, 19 Jun 2020 at 09:24, Ngai Elizabeth ***@***.***>
wrote:
> This is a fix in issue #1555
> <#1555>. The Patient
> 'Issues' now does not display incorrect date without entry.
>
> please can you send us a screenshot of the fix.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#1617 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AOQABPC2ETOXDBH5J3AFB5DRXMODBANCNFSM4OCPY3NQ>
> .
>
|
muarachmann
requested changes
Jun 26, 2020
| echo " <td>" . text(date(DateFormatRead(true), strtotime($row['begdate']))) . " </td>\n"; | ||
| echo " <td>" . text(date(DateFormatRead(true), strtotime($row['enddate']))) . " </td>\n"; | ||
| echo " <td>" . text($row['begdate']) . " </td>\n"; | ||
| echo " <td>" . text($row['enddate']) . " </td>\n"; |
There was a problem hiding this comment.
This is not the right approach! Just check if the value is NULL or "" then show a default -, the functions there are not be removed
|
ok
…On Fri, 26 Jun 2020 at 04:39, muarachmann ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In interface/patient_file/summary/stats_full.php
<#1617 (comment)>:
> @@ -285,8 +285,8 @@ function newEncounter() {
echo " <tr class='$bgclass detail' $colorstyle>\n";
echo " <td style='text-align:left' data-text='$disptitle' class='$click_class' id='$rowid'>" . text($disptitle) . "</td>\n";
- echo " <td>" . text(date(DateFormatRead(true), strtotime($row['begdate']))) . " </td>\n";
- echo " <td>" . text(date(DateFormatRead(true), strtotime($row['enddate']))) . " </td>\n";
+ echo " <td>" . text($row['begdate']) . " </td>\n";
+ echo " <td>" . text($row['enddate']) . " </td>\n";
This is not the right approach! Just check if the value is NULL or ""
then show a default -, the functions there are not be removed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1617 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQABPBX4CGVPEWF76TIYATRYQJ63ANCNFSM4OCPY3NQ>
.
|
|
I will fix that
…On Fri, 26 Jun 2020 at 08:21, ahani peitra ***@***.***> wrote:
ok
On Fri, 26 Jun 2020 at 04:39, muarachmann ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
> ------------------------------
>
> In interface/patient_file/summary/stats_full.php
> <#1617 (comment)>
> :
>
> > @@ -285,8 +285,8 @@ function newEncounter() {
>
> echo " <tr class='$bgclass detail' $colorstyle>\n";
> echo " <td style='text-align:left' data-text='$disptitle' class='$click_class' id='$rowid'>" . text($disptitle) . "</td>\n";
> - echo " <td>" . text(date(DateFormatRead(true), strtotime($row['begdate']))) . " </td>\n";
> - echo " <td>" . text(date(DateFormatRead(true), strtotime($row['enddate']))) . " </td>\n";
> + echo " <td>" . text($row['begdate']) . " </td>\n";
> + echo " <td>" . text($row['enddate']) . " </td>\n";
>
> This is not the right approach! Just check if the value is NULL or ""
> then show a default -, the functions there are not be removed
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#1617 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AOQABPBX4CGVPEWF76TIYATRYQJ63ANCNFSM4OCPY3NQ>
> .
>
|
muarachmann
requested changes
Jul 4, 2020
| echo " <td>" . text($row['begdate']) . " </td>\n"; | ||
| echo " <td>" . text($row['enddate']) . " </td>\n"; | ||
| echo " <td>" . text(date(DateFormatRead(true), date($row['begdate']))) . " </td>\n"; | ||
| echo " <td>" . text(date(DateFormatRead(true), date($row['enddate']))) . " </td>\n"; |
There was a problem hiding this comment.
Yes we need some if/else statement here for blank dates
|
I tried the if/else statement but it was not functional then noticed the
problem was caused by the "strtotime()" which outputs 1970 01 01 as date by
default so thats y i changed it to a normal date
…On Sat, 4 Jul 2020 at 01:55, muarachmann ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In interface/patient_file/summary/stats_full.php
<#1617 (comment)>:
> @@ -285,8 +285,8 @@ function newEncounter() {
echo " <tr class='$bgclass detail' $colorstyle>\n";
echo " <td style='text-align:left' data-text='$disptitle' class='$click_class' id='$rowid'>" . text($disptitle) . "</td>\n";
- echo " <td>" . text($row['begdate']) . " </td>\n";
- echo " <td>" . text($row['enddate']) . " </td>\n";
+ echo " <td>" . text(date(DateFormatRead(true), date($row['begdate']))) . " </td>\n";
+ echo " <td>" . text(date(DateFormatRead(true), date($row['enddate']))) . " </td>\n";
Yes we need some if/else statement here for blank dates
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1617 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQABPE6HIYDQG3WZ5KP25TRZZ4W7ANCNFSM4OCPY3NQ>
.
|
|
@ahanipeitra1994 it seems to still show the default timedate for me, even with date(). Can you push the if/else statements that you used? We can help guide you to a working solution if we can see the code. |
|
ok i will do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix on issue #1555. The Patient 'Issues' now does not display incorrect date without entry.