add openai streaming #101
Merged
add openai streaming #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
===================================
- Coverage 81% 79% -2%
===================================
Files 13 13
Lines 743 806 +63
===================================
+ Hits 599 633 +34
- Misses 144 173 +29 |
lantiga
reviewed
May 21, 2024
lantiga
reviewed
May 21, 2024
lantiga
reviewed
May 21, 2024
lantiga
reviewed
May 21, 2024
lantiga
reviewed
May 21, 2024
lantiga
reviewed
May 21, 2024
…serve into aniket/openai-streaming
lantiga
reviewed
May 22, 2024
lantiga
reviewed
May 22, 2024
There was a problem hiding this comment.
Looks good, one comment, and it's missing changes to the README.md (which is now incompatible with what is in here).
Also we need to produce a good error message for when the user returns from predict instead of yielding ("OpenAISpec requires predict to be streaming... etc")
|
@lantiga added validation to ensure that |
…serve into aniket/openai-streaming
lantiga
approved these changes
May 23, 2024
|
Looks good, let's see if tests pass and we merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR converts the existing OpenAI Spec to return streaming response