Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: cover disabled request timeout scenario for collate_requests #167

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Jul 9, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

Missed to cover disabled timeout in scenario in collate_requests in #164. This PR, fixes that by handling timeout=False and timeout=-1 cases.

PS: Reran the benchmark to confirm there is no perf loss.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (450bc08) to head (a8b63f7).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #167   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        13     13           
  Lines       946    947    +1     
===================================
+ Hits        734    735    +1     
  Misses      212    212           

@aniketmaurya aniketmaurya changed the title bugfix: request timeout -1 or False for collate_request was not covered bugfix: cover disabled request timeout scenario for collate_requests Jul 9, 2024
src/litserve/server.py Outdated Show resolved Hide resolved
@aniketmaurya aniketmaurya mentioned this pull request Jul 11, 2024
4 tasks
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aniketmaurya aniketmaurya merged commit 0c70c20 into main Jul 11, 2024
19 checks passed
@aniketmaurya aniketmaurya deleted the bugfix/fix-timeout branch July 11, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants