Fix: Support files > 1MB #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
===================================
Coverage 78% 78%
===================================
Files 13 13
Lines 946 949 +3
===================================
+ Hits 734 737 +3
Misses 212 212 |
aniketmaurya
approved these changes
Jul 11, 2024
|
about this, we should have the ability to reject large uploads (max size configurable), or a ill intentioned consumer of the api could upload a huge file and crash the server |
|
@lantiga Yeah, this PR works around a technical limitation preventing us from supporting larger requests. For that, I would recommend a different approach. I'd attach a middleware to FastAPI to return a proper 413 HTTP code on some configurable size. |
|
yes definitely, that’s also what I was thinking above |
|
created an issue here #171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
This PR allows files that are larger than 1MB to be uploaded.
For files larger than 1MB uploaded with FastAPI, it creates a SpooledTemporaryFile which is partially written to disk as described here. This prevents pickling of the form by the multiprocess library and crashes the request.
This PR sets the limit to an extremely large number so the file is always kept entirely in memory. This allows the file to be serialized correctly. Effectively, this limits the max file size for LitServe to the amount of RAM available on the machine.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃