Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: adds health check endpoint #182

Merged
merged 13 commits into from
Jul 29, 2024

Conversation

bhimrazy
Copy link
Contributor

@bhimrazy bhimrazy commented Jul 26, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #181 .

  • Adds health check endpoint /health to get the status of workers

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy marked this pull request as draft July 26, 2024 20:21
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (16efafe) to head (492bad5).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #182   +/-   ##
===================================
  Coverage    79%    79%           
===================================
  Files        13     13           
  Lines       991   1003   +12     
===================================
+ Hits        780    792   +12     
  Misses      211    211           

Copy link
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far @bhimrazy 🚀 !! Added a comment. Also, please add a test. Looking forward to this PR.

src/litserve/server.py Outdated Show resolved Hide resolved
src/litserve/server.py Outdated Show resolved Hide resolved
@aniketmaurya aniketmaurya added the enhancement New feature or request label Jul 26, 2024
@bhimrazy bhimrazy marked this pull request as ready for review July 27, 2024 18:50
@aniketmaurya aniketmaurya merged commit 5161c9d into Lightning-AI:main Jul 29, 2024
19 checks passed
@bhimrazy bhimrazy deleted the feat/health-check-endpoint branch July 29, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add health check endpoint
2 participants