Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale uvicorn servers #186

Merged
merged 46 commits into from
Aug 2, 2024
Merged

scale uvicorn servers #186

merged 46 commits into from
Aug 2, 2024

Conversation

aniketmaurya
Copy link
Collaborator

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya marked this pull request as ready for review August 1, 2024 19:10
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 79%. Comparing base (4d5d146) to head (7597b16).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #186   +/-   ##
===================================
- Coverage    80%    79%   -1%     
===================================
  Files        13     13           
  Lines      1003   1031   +28     
===================================
+ Hits        807    816    +9     
- Misses      196    215   +19     

_requirements/test.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great job @aniketmaurya

src/litserve/server.py Outdated Show resolved Hide resolved
@aniketmaurya aniketmaurya enabled auto-merge (squash) August 2, 2024 10:27
@aniketmaurya aniketmaurya merged commit ba1f692 into main Aug 2, 2024
19 checks passed
@aniketmaurya aniketmaurya deleted the aniket/parallel-servers branch August 2, 2024 11:11
@bhimrazy
Copy link
Contributor

bhimrazy commented Aug 2, 2024

This PR on scaling Uvicorn servers looks like a great feature, @aniketmaurya 🎉
I’m looking forward to exploring it and learning more! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants