Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #219

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Fix flaky test #219

merged 6 commits into from
Aug 23, 2024

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Aug 23, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fix flaky parity tests

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80%. Comparing base (a2901bf) to head (f0f5a02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #219   +/-   ##
===================================
  Coverage    80%    80%           
===================================
  Files        13     13           
  Lines      1057   1057           
===================================
  Hits        850    850           
  Misses      207    207           

@aniketmaurya aniketmaurya marked this pull request as ready for review August 23, 2024 19:32
@aniketmaurya aniketmaurya enabled auto-merge (squash) August 23, 2024 20:12
@williamFalcon williamFalcon merged commit 238db27 into main Aug 23, 2024
20 checks passed
@williamFalcon williamFalcon deleted the aniket/fix-flaky-test branch August 23, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants