Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of IdentityAPI class in test #222

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

eltociear
Copy link
Contributor

@eltociear eltociear commented Aug 26, 2024

Indentity -> Identity

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fix spelling of IdentityAPI in test_lit_server.py

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Indentity -> Identity
Copy link
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the PR @eltociear 🚀

@aniketmaurya aniketmaurya changed the title docs: update test_lit_server.py Fix spelling of IdentityAPI class in test Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82%. Comparing base (7923bc4) to head (79e86fe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #222   +/-   ##
===================================
  Coverage    82%    82%           
===================================
  Files        13     13           
  Lines      1048   1048           
===================================
  Hits        855    855           
  Misses      193    193           

@williamFalcon williamFalcon merged commit 0a6045a into Lightning-AI:main Aug 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants