Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast when LitAPI.setup has error #356

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Conversation

aniketmaurya
Copy link
Collaborator

@aniketmaurya aniketmaurya commented Nov 7, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #347

LitServe doesn't crash when there is an error in the LitAPI.setup method. This PR makes LitServe fail when setup has error.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@aniketmaurya aniketmaurya changed the title Fast fail LitServe - discover errors quicker Fail fast when LitAPI.setup has error Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 96%. Comparing base (23ba5e2) to head (2c54cb7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #356   +/-   ##
===================================
- Coverage    96%    96%   -0%     
===================================
  Files        22     22           
  Lines      1394   1408   +14     
===================================
+ Hits       1332   1345   +13     
- Misses       62     63    +1     

@aniketmaurya aniketmaurya self-assigned this Nov 7, 2024
@aniketmaurya aniketmaurya added the enhancement New feature or request label Nov 7, 2024
@aniketmaurya aniketmaurya enabled auto-merge (squash) November 7, 2024 19:41
@aniketmaurya aniketmaurya merged commit 42399b2 into main Nov 7, 2024
19 of 20 checks passed
@aniketmaurya aniketmaurya deleted the aniket/fast-fail branch November 7, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LitServe server doesn't crash when there is a failure in setup
3 participants